Repository navigation
Build: Add new Webpack plugin to handle library default export - #6935
Merged
Merged
Conversation
4 tasks done
gziolo
force-pushed
the
add/library-export-default-plugin
branch
2 times, most recently
from
May 24, 2018 13:08
cfe7696 to
d46845a
Compare
gziolo
force-pushed
the
add/library-export-default-plugin
branch
from
May 24, 2018 13:16
d46845a to
f71b609
Compare
aduth
approved these changes
May 25, 2018
aduth
left a comment
Member
There was a problem hiding this comment.
Looks (and works) great 👍
Unfortunate that we can't detect this automatically. Guessing that's impossible / prohibitively difficult to implement. At least for the time being, I'm more concerned with avoiding developers coming to expect the .default property to exist.
19 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6748.
I played with the different approaches proposed in #6748 and ended up implementing a custom Webpack plugin, which works very similar to what
libraryExport: 'default'does as explained in Webpack docs:Plugin's implementation is based on the ExportPropertyMainTemplatePlugin core plugin. The only difference in here is that instead of applying this transformation to all entry points, we will be able to provide the list of chunks where this should be applied:
How has this been tested?
Make sure
npm run devandnpm run buildwork properly.It should be possible to execute the following code on the JS console when running Gutenberg:
Checklist: